Closed Bug 1844510 Opened 2 years ago Closed 2 years ago

118.9 - 21.69% bing-search FirstVisualChange + 12 more (Linux) regression on Thu July 20 2023

Categories

(Core :: Graphics: WebRender, defect)

Product:
Core
Component:
Graphics: WebRender
Version:
Firefox 117
Platform:
Desktop
Linux
Type:
defect

Tracking

()

Status:
RESOLVED WONTFIX
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- unaffected
firefox115 --- unaffected
firefox116 --- unaffected
firefox117 --- wontfix
firefox118 --- wontfix

People

(Reporter: afinder, Unassigned)

References

(Regression)

Details

(Keywords: perf, perf-alert, regression)

Perfherder has detected a browsertime performance regression from push e1c387461f1491b8b63445d4505d5617392ed527. As author of one of the patches included in that push, we need your help to address this regression.

== Change summary for alert #39052 (as of Tue, 18 Jul 2023 10:28:49 GMT) ==

Regressions:

Ratio Test Platform Options Absolute values (old vs new) Performance Profiles
22% bing-search FirstVisualChange linux1804-64-shippable-qr bytecode-cached fission warm webrender 97.74 -> 118.93 Before/After
19% bing-search ContentfulSpeedIndex linux1804-64-shippable-qr bytecode-cached fission warm webrender 113.13 -> 134.81 Before/After
18% bing-search ContentfulSpeedIndex linux1804-64-shippable-qr fission warm webrender 103.02 -> 121.34 Before/After
17% bing-search FirstVisualChange linux1804-64-shippable-qr fission warm webrender 94.20 -> 110.36 Before/After
17% bing-search FirstVisualChange linux1804-64-shippable-qr bytecode-cached fission warm webrender 100.15 -> 117.13 Before/After
15% bing-search FirstVisualChange linux1804-64-shippable-qr fission warm webrender 94.15 -> 108.65 Before/After
12% bing-search fcp linux1804-64-shippable-qr bytecode-cached fission warm webrender 83.55 -> 93.93 Before/After
12% bing-search fcp linux1804-64-shippable-qr fission warm webrender 81.15 -> 91.09 Before/After
10% bing-search SpeedIndex linux1804-64-shippable-qr bytecode-cached fission warm webrender 181.88 -> 200.12 Before/After
9% bing-search SpeedIndex linux1804-64-shippable-qr fission warm webrender 178.43 -> 194.79 Before/After
2% bing-search PerceptualSpeedIndex linux1804-64-shippable-qr bytecode-cached fission warm webrender 411.97 -> 422.03 Before/After
2% bing-search PerceptualSpeedIndex linux1804-64-shippable-qr fission warm webrender 404.98 -> 414.53 Before/After
2% motionmark-htmlsuite linux1804-64-shippable-qr fission webrender 60.36 -> 59.10 Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39052

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Set release status flags based on info from the regressing bug 1836668

:jan, since you are the author of the regressor, bug 1836668, could you take a look?

For more information, please visit BugBot documentation.

status-firefox115: --- → unaffected
status-firefox116: --- → unaffected
status-firefox-esr102: --- → unaffected
status-firefox-esr115: --- → unaffected
Flags: needinfo?(jan)

Something is wrong with our simulation of loading this bing search result page. If you open the profiles and look at the screenshots you see the images in the top right load and display, and then get replaced by their alt text, and stay that way. Maybe you can redirect this needinfo to someone who might know why this happens/how to fix it?

Flags: needinfo?(gmierz2)
See Also: → 1844423

It's an issue in mitmproxy or how it was recorded. We can try to re-record it, but I don't think it'll change this regression since it seems to be related to the FirstVisualChange regression when I look at the side-by-side's and videos. Filed this bug for bing-search re-recording: https://bugzilla.mozilla.org/show_bug.cgi?id=1844552

Flags: needinfo?(gmierz2)

(I'm a tester, not a programmer, this was one of my few patches.)

Software WebRender, HW WR/Xwayland and HW WR/Nvidia already have this behavior (they use the software timer) and require it (bug 1836668 comment 0).
The CI is testing blocklisted force-enabled "hardware" WebRender on llvmpipe (slow software OpenGL) on legacy X11: The new timing seems mostly within 1 frame (1000ms/60fps=16,66ms).
The patch should be kept for complexity reduction and stability (bug 1836668 comment 0), this legacy X11 bug should be wontfixed IIUC.
Wayland (bug 1813588) should be used&tested for best results.

Flags: needinfo?(jan)

Set release status flags based on info from the regressing bug 1836668

status-firefox118: --- → affected
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox117: affected → wontfix
status-firefox118: affected → wontfix
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.